Add gpsampler #2995
Open
Add gpsampler #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
I did not realize that I basically duplicated #2360. Can we merge one of these in? |
|
It also appears that the workflows for CI do not trigger with a PR from a forked branch. |
himkt
approved these changes
Jan 19, 2025
himkt
reviewed
Jan 19, 2025
|
Hello @jesszzzz, can we ask you to review the PR? |
|
Let me kindly ping @jesszzzz. |
|
Sorry for the delay! I do expect some tests will break from this, #3020 enables running CI on forked PRs so please rebase when that's merged. Otherwise these changes look fine to me! |
|
Thank you for letting us know! |
michaelriedl
force-pushed
the
add-gpsampler
branch
from
b3bd748 to
e012c26
Compare
|
@jesszzzz it looks like you need to approve the 2 workflows to run since I am a first time contributor. I ran all the Pytest tests locally without issue, just need to run the workflows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I wanted to bring the Optuna plugin up to date with the newest version. I made the necessary changes to make the plugin compatible. I also added in the GPSampler even though it is still experimental since some people may want to use it.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
I modified the existing tests in the plugin folder. I have tested that they pass on my WSL setup.
Related Issues and PRs
Issues:
#2562
#2162
PRs:
#2360